Updates for latest Django supported versions#129
Updates for latest Django supported versions#129dakrauth wants to merge 2 commits intoencode:masterfrom
Conversation
dakrauth
force-pushed
the
supported-django-versions
branch
2 times, most recently
from
fad2daf to
f5a1309
Compare
|
Any chance of getting this PR approved? Or, more than happy to take on maintenance of / contribution to the project, I use it quite a bit. |
|
Hi! Thanks for your work here @dakrauth . I'd love to take a more active role maintaining django-vanilla-views. I like it a lot too—even if I haven't had a chance to use it more recently, I still mention it to others. @tomchristie - at DjangoCon Europe we discussed transferring the repo to me. Would you be willing to do that now? |
| - 3.7 | ||
| - 3.8 | ||
| - 3.9 | ||
| python-version: ["3.10", "3.11", "3.12", "3.13"] |
There was a problem hiding this comment.
| python-version: ["3.10", "3.11", "3.12", "3.13"] | |
| python-version: ["3.10", "3.11", "3.12", "3.13", "3.14"] |
There was a problem hiding this comment.
Is adding 3.14 here correct? As of today, the latest commit for pre-6.0 only mentions supported 3.12 and 3.13.
In theory, I'd entirely be onboard with adding a non-failing check run against 3.14, but considering the time delta since this pull request was opened, I'd rather chalk that up to nice-to-have vs. a hard requirement.
There was a problem hiding this comment.
https://code.djangoproject.com/ticket/35844
Django 5.2 will be the first version to support Python 3.14, because Django 5.1 will end the mainstream support in April 2024.
https://forum.djangoproject.com/t/which-versions-of-django-will-support-python-3-14/43005
.github/workflows/main.yml
Outdated
| - uses: actions/setup-python@v5 | ||
| with: | ||
| python-version: ${{ matrix.python-version }} |
There was a problem hiding this comment.
| - uses: actions/setup-python@v5 | |
| with: | |
| python-version: ${{ matrix.python-version }} | |
| - uses: actions/setup-python@v6 | |
| with: | |
| python-version: ${{ matrix.python-version }} | |
| allow-prereleases: true |
There was a problem hiding this comment.
allow-prereleases: true is no longer needed because Py3.14 has been released.
There was a problem hiding this comment.
Perhaps now use allow-prereleases if 3.14 isn't official recognized as of yet for the upcoming Django 6 release?
There was a problem hiding this comment.
actions/setup-python's allow-prereleases pertains to Python pre-releases, not to Django pre-releases. Currently, it will enable testing on python3.15.0-alpha.1 and is no longer needed for Python 3.14 testing.
https://code.djangoproject.com/ticket/35844
Django 5.2 will be the first version to support Python 3.14, because Django 5.1 will end the mainstream support in April 2024.
| * **Django**: 2.2, 3.0, 3.1, 3.2 | ||
| * **Python**: 3.6, 3.7, 3.8, 3.9 | ||
| * **Django**: 4.2, 5.0, 5.1, 5.2 | ||
| * **Python**: 3.10, 3.11, 3.12, 3.13 |
There was a problem hiding this comment.
| * **Python**: 3.10, 3.11, 3.12, 3.13 | |
| * **Python**: 3.10, 3.11, 3.12, 3.13, 3.14 |
There was a problem hiding this comment.
Please see previous 3.14 comment.
There was a problem hiding this comment.
https://code.djangoproject.com/ticket/35844
Django 5.2 will be the first version to support Python 3.14, because Django 5.1 will end the mainstream support in April 2024.
|
Would be nice to see this continue. |
|
Does anyone know who else might be able to provide a review? @cclauss? @adamchainz? |
|
I already approved, but I am not an encode maintainer. |
|
Looks like I still need someone with write permissions to approve the PR. Does anyone following this PR know anyone at Encode? |
|
@lovelydinosaur has granted me permissions - I will merge and do some other updates soon. |
|
Thank you @adamchainz. If possible, I would love to be write-able contributor, I have several improvements I'd like to make, such as converting the project to using |
|
Sending a ping @adamchainz |
|
Hello and thank you to everyone who has contributed to this PR. After 9+ months since the initial PR being opened, I have to move on. I rely on and use this package, but there is obviously minimal support for maintaining it going forward. As such, I have created a fork called Django Vanilla Extract that I have modernized a bit to use uv, pytest, etc. My plan is publish to PyPI next month and would love any/all feedback, but would rather that DVV somehow show some signs of life. If not, I personally need to move forward. Again, thanks everyone -- @adamchainz, in particular I appreciate your publishing focus and I hope I haven't disappointed you overmuch. |
4 participants
Added support for Django >= 4.2, including 5.2.
Fixes PR #130