NXT-14640: fixed various less files and removed orphan variables

[daniel-stoian-lgp]

Checklist

• I have read and understand the contribution guide
• A CHANGELOG entry is included
• At least one test case is included for this feature or bug fix
• Documentation was added or is not needed
• This is an API breaking change

Issue Resolved / Feature Added

Less files in Limestone required review for efficiency.

Resolution

• Variables.less, colors.less, motion-mixins.less: removed orphan variables; removed duplicated @lime-header-mini-margin
• colors-game.less: changed variable names in colors-game.less, so they point to the right setting and override a normal mode color variable (which was broken when limestone was first developed) I used sandstone logic to detect the right variable name
• Checkbox, RadioItem : removed redundant setting of "--icon-size". These became redundant when Icon component was adapted for largeText mode in NXT-13477: Large Text for Icon component #351
• Checkbox, Scroller: replaced enact-locale-rtl() with padding-start-end(), which does the same, but with less written stylings + removed the now redundant less variables.
• Input.module.less: concatenated duplicated .input{} blocks
• InputField.module.less: removed commented code and moved styling block before applySkins()
• Picker.module.less: concatenated duplicated .item{} blocks
• Item.module.less: moved styling block for child class after stylings for main class; Added .bg() background (@lime-item-focus-background is transparent for Default skin) so it can support game skin customization
• MediaSlider.module.less: removed commented code
• Panels/Header.module.less: concatenated duplicate slotAfter blocks and moved all "Slot*" blocks to be one enxt to the other; concatenated dupliacate .title{} blocks. concatenated duplicated &.wizard {} blocks

Additional Considerations

Fixed some duplicate screenshot tests entries for slider, which was causing comparisons between focused and unfocused component, in the same test run (check screenshot tests job in the user story)

Links

NXT-14640

Comments

Enact-DCO-1.0-Signed-off-by: Daniel Stoian (daniel.stoian@lgepartner.com)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.97%. Comparing base (8983909) to head (543231a).

Additional details and impacted files

@@           Coverage Diff            @@
##           develop     #363   +/-   ##
========================================
  Coverage    81.97%   81.97%           
========================================
  Files          153      153           
  Lines         7480     7480           
  Branches      2251     2251           
========================================
  Hits          6132     6132           
  Misses        1043     1043           
  Partials       305      305           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.