Skip to content

NXT-14650 [2027TV] Adapt ProgressBar and Slider to latest UX Guide#359

Merged
daniel-stoian-lgp merged 20 commits into
developfrom
feature/NXT-14650
Jun 2, 2026
Merged

NXT-14650 [2027TV] Adapt ProgressBar and Slider to latest UX Guide#359
daniel-stoian-lgp merged 20 commits into
developfrom
feature/NXT-14650

Conversation

@dan-ichim-lgp
Copy link
Copy Markdown
Contributor

@dan-ichim-lgp dan-ichim-lgp commented May 27, 2026

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Updated ProgressBar and Slider component styling to match the latest UX Guide (webOS 27 Component Foundation).

Resolution

The changes align both components with the latest design specifications

Additional Considerations

Links

NXT-14650

Comments

Enact-DCO-1.0-Signed-off-by: Dan Ichim (dan.ichim@lgepartner.com)

@dan-ichim-lgp dan-ichim-lgp changed the base branch from master to develop May 27, 2026 11:04
@dan-ichim-lgp dan-ichim-lgp changed the title Feature/nxt 14650 NXT-14650 [2027TV] Adapt ProgressBar and Slider to latest UX Guide May 27, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.97%. Comparing base (4387fb1) to head (aaca876).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #359   +/-   ##
========================================
  Coverage    81.97%   81.97%           
========================================
  Files          153      153           
  Lines         7480     7480           
  Branches      2251     2251           
========================================
  Hits          6132     6132           
  Misses        1043     1043           
  Partials       305      305           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

@alexandrumorariu alexandrumorariu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread ProgressBar/ProgressBar.module.less Outdated
Copy link
Copy Markdown
Contributor

@daniel-stoian-lgp daniel-stoian-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

check existing comments and apply the fixes. I will resume the review after tyou fix them

Comment thread styles/variables.less Outdated
Comment thread CHANGELOG.md
Comment thread MediaPlayer/MediaSlider.module.less
Comment thread Slider/Slider.module.less Outdated
@daniel-stoian-lgp
Copy link
Copy Markdown
Contributor

  1. my apologies, i see why the border-radiu was needed in progressBar. It is needed in slider with colorPicker. can you add it back?

  2. ColorPicker slider need to be vertically centered in it's parent container

image

Comment thread styles/colors.less Outdated
Comment thread Slider/Slider.module.less Outdated
Comment thread Slider/Slider.module.less Outdated
Comment thread styles/variables.less Outdated
@daniel-stoian-lgp
Copy link
Copy Markdown
Contributor

@dan-ichim-lgp , please check disabled state:
knob is now visible when slider is disabled and not hovered:
image

On develop branch, as well and in the UX Guide, the know is not visible when disabled and not hovered

Comment thread styles/colors.less
Comment thread Slider/Slider.module.less
@daniel-stoian-lgp daniel-stoian-lgp merged commit 8983909 into develop Jun 2, 2026
6 checks passed
@daniel-stoian-lgp daniel-stoian-lgp deleted the feature/NXT-14650 branch June 2, 2026 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants