NXT-8995: Adapt Agate code to respect React Compiler#854
Merged
daniel-stoian-lgp merged 9 commits intodevelopfrom Apr 8, 2026
Merged
NXT-8995: Adapt Agate code to respect React Compiler#854daniel-stoian-lgp merged 9 commits intodevelopfrom
daniel-stoian-lgp merged 9 commits intodevelopfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #854 +/- ##
===========================================
- Coverage 85.08% 85.06% -0.02%
===========================================
Files 118 118
Lines 4491 4493 +2
Branches 1226 1226
===========================================
+ Hits 3821 3822 +1
- Misses 517 518 +1
Partials 153 153 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
ion-andrusciac-lgp
approved these changes
Jan 30, 2026
# Conflicts: # samples/perf-virtuallist-native-with-different-item-size/src/views/HorizontalDifferentWidthItemList.js # samples/perf-virtuallist-native-with-different-item-size/src/views/VerticalDifferentHeightItemList.js # samples/perf-virtuallist-native-with-different-item-size/src/views/VerticalExpandableDifferentHeightItemList.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Adapted Agate code to respect React Compiler
Resolution
eslint-plugin-react-hooks 7.x has React Compiler embedded. The code needs to be adapted to respect Eslint rules
Additional Considerations
Some of the errors were silenced as they were considered false positives (future investigation may be required)
Links
NXT-8995
Comments