WT-13785: Consider column in WTableView::scrollTo#243
Closed
m-seibt wants to merge 4 commits intoemweb:masterfrom
Closed
WT-13785: Consider column in WTableView::scrollTo#243m-seibt wants to merge 4 commits intoemweb:masterfrom
m-seibt wants to merge 4 commits intoemweb:masterfrom
Conversation
|
Thanks for the pr, however, we will not be using this code. The reason is that we already implemented this and it is planned for 4.13.0 (which we hope to release next month). I will however make it available on the master branch as soon as the review process is finish. Note that when we set a ticket status to |
Contributor
Author
|
48129ca works like a charm. Thank you. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves https://redmine.emweb.be/issues/13785
Based on some refactoring being part of #241, too
Hard to test with Wt 4.12.5 because the layout of WTableView is messed up