Consolidate test_multidynamic_link and test_multiply_defined_libsymbols. NFC#26986
Merged
sbc100 merged 1 commit intoMay 21, 2026
Merged
Conversation
test_multidynamic_link and test_multiply_defined_libsymbolstest_multidynamic_link and test_multiply_defined_libsymbols. NFC
Collaborator
Author
|
I suspected these two tests were redundant, so I had gemini analyze them and got these results. I've confirmed that test_multidynamic_link and test_multiply_defined_libsymbols were largely redundant. Both were testing that Emscripten's "fake dylib" model (where .so files are treated Comparison
Action Taken
|
kripken
reviewed
May 21, 2026
…mbols` Since these tests were largely redundant, consolidate them into a single parameterized test. Specifically, test_multiply_defined_libsymbols was more comprehensive but test_multidynamic_link tested versioned suffixes and full path linking. test_multiply_defined_libsymbols now covers those cases.
0581179 to
e953387
Compare
dschuff
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since these tests were largely redundant, consolidate them into a single parameterized test. Specifically,
test_multiply_defined_libsymbolswas more comprehensive buttest_multidynamic_link testedversioned suffixes and full path linking.test_multiply_defined_libsymbolsnow covers those cases.