Skip to content

Use scheduler.postTask when implementing EM_TIMING_SETIMMEDIATE #26985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
May 21, 2026
+14 −4
Merged

Use scheduler.postTask when implementing EM_TIMING_SETIMMEDIATE #26985

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/closure-externs/closure-externs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -234,3 +234,5 @@ Navigator.prototype.webkitGetUserMedia = function(
var os = {};

AudioWorkletProcessor.parameterDescriptors;

var scheduler = {};
12 changes: 10 additions & 2 deletions src/lib/libeventloop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -341,11 +341,19 @@ LibraryJSEventLoop = {
assert(mode == {{{ cDefs.EM_TIMING_SETIMMEDIATE}}});
#endif
if (!MainLoop.setImmediate) {
if (globalThis.setImmediate) {
if (globalThis.scheduler) {
// Some modern browsers implement scheduler.postTask, but not all.
#if RUNTIME_DEBUG
dbg('setImmediate: using scheduler.postTask');
#endif
MainLoop.setImmediate = scheduler.postTask.bind(scheduler);
#if ENVIRONMENT_MAY_BE_NODE
} else if (globalThis.setImmediate) {
MainLoop.setImmediate = setImmediate;
#endif
} else {
#if RUNTIME_DEBUG
dbg('using polyfill for setImmediate');
dbg('setImmediate: using polyfill');
#endif
// Emulate setImmediate. (note: not a complete polyfill, we don't emulate clearImmediate() to keep code size to minimum, since not needed)
var setImmediates = [];
Expand Down
4 changes: 2 additions & 2 deletions test/codesize/test_codesize_hello_dylink_all.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"a.out.js": 268108,
"a.out.js": 268175,
"a.out.nodebug.wasm": 587563,
"total": 855671,
"total": 855738,
"sent": [
"IMG_Init",
"IMG_Load",
Expand Down
Loading