Skip to content

[js_optimizer] Use existing globals. NFC #26980

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
May 20, 2026
+4 −6
Merged

[js_optimizer] Use existing globals. NFC #26980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions tools/js_optimizer.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,13 +276,11 @@ def write_chunk(chunk, i):
with ToolchainProfiler.profile_block('split_closure_cleanup'):
if closure or cleanup:
# run on the shell code, everything but what we acorn-optimize
start_asm = '// EMSCRIPTEN_START_ASM\n'
end_asm = '// EMSCRIPTEN_END_ASM\n'
cl_sep = 'wakaUnknownBefore(); var asm=wakaUnknownAfter(wakaGlobal,wakaEnv,wakaBuffer)\n'

with temp_files.get_file('.cl.js') as cle:
pre_1, pre_2 = pre.split(start_asm)
post_1, post_2 = post.split(end_asm)
pre_1, pre_2 = pre.split(start_asm_marker)
post_1, post_2 = post.split(end_asm_marker)
with open(cle, 'w', encoding='utf-8') as f:
f.write(pre_1)
f.write(cl_sep)
Expand All @@ -303,7 +301,7 @@ def write_chunk(chunk, i):
temp_files.note(cld)
coutput = utils.read_file(cld)

coutput = coutput.replace('wakaUnknownBefore();', start_asm)
coutput = coutput.replace('wakaUnknownBefore();', start_asm_marker)
after = 'wakaUnknownAfter'
start = coutput.find(after)
end = coutput.find(')', start)
Expand All @@ -318,7 +316,7 @@ def write_chunk(chunk, i):
brace = pre_2.find('{', brace) + 1
has_useless_code_comment = True
pre = coutput[:start] + '(' + (USELESS_CODE_COMMENT if has_useless_code_comment else '') + 'function(global,env,buffer) {\n' + pre_2[brace:]
post = post_1 + end_asm + coutput[end + 1:]
post = post_1 + end_asm_marker + coutput[end + 1:]

filename += '.jo.js'
temp_files.note(filename)
Expand Down
Loading