Avoid hang when remainder_ns = 0#26586
Closed
stephenduong1004 wants to merge 1 commit intoemscripten-core:mainfrom
Closed
Avoid hang when remainder_ns = 0#26586stephenduong1004 wants to merge 1 commit intoemscripten-core:mainfrom
stephenduong1004 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
Collaborator
|
Nice! That looks like a more likely source of the recent hang we have been seeing. |
Collaborator
|
Is there some way to write a test for it? Would calling emscripten_futex_wait(timeout=0) on the main thread catch it? |
sbc100
approved these changes
Mar 31, 2026
Collaborator
sbc100
left a comment
sbc100
left a comment
There was a problem hiding this comment.
lgtm, even better if we can find a way to test it.
Collaborator
|
@stephenduong1004 I tried to push a change to this PR to add a test but it seems like there are permissions issues? (I think if you look at your repo settings you can enable, upstream contributors in emscripten to push changes to your PR branches, but I can't remember exactly what that settings is called). In the interest of getting this landed today I'll maybe start a separate PR? |
sbc100
pushed a commit
to sbc100/emscripten
that referenced
this pull request
Mar 31, 2026
This bug was introduced in emscripten-core#26471. This PR is based on emscripten-core#26586. Thanks @stephenduong1004!
sbc100
pushed a commit
to sbc100/emscripten
that referenced
this pull request
Mar 31, 2026
This bug was introduced in emscripten-core#26471. This PR is based on emscripten-core#26586. Thanks @stephenduong1004!
Collaborator
|
Closing in a favor of #26588 |
sbc100
added a commit
that referenced
this pull request
Apr 1, 2026
This bug was introduced in #26471. This PR is based on #26586. Thanks @stephenduong1004! Co-authored-by: stephenduong1004 <stephenduong@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This bug was introduced in #26471