Remove loop from emscripten_thread_sleep. NFC#26585
Open
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Open
Remove loop from emscripten_thread_sleep. NFC#26585sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
sbc100 wants to merge 1 commit intoemscripten-core:mainfrom
Conversation
sbc100
force-pushed
the
emscripten_thread_sleep
branch
3 times, most recently
from
c8d8cfa to
6fa2130
Compare
We have code in the lower level emscrpeten_futex_wait that take care of splitting up the wait for the main runtime thread. For normal pthreads I don't see any need to run the message queue while the thread is sleeping like this. Instead, it can run from the event loop, or explicitly run. Followup to emscripten-core#26471
sbc100
force-pushed
the
emscripten_thread_sleep
branch
from
6fa2130 to
a5a8564
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have code in the lower level emscrpeten_futex_wait that take care of splitting up the wait for the main runtime thread. For normal pthreads I don't see any need to run the message queue while the thread is sleeping like this.
Instead, it can run from the event loop, or explicitly run.
Followup to #26471