[embind] Remove relaxed SIMD during TS generation #26255
+42
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Older versions of Node.js do not support relaxed SIMD instructions, which causes errors when running the Wasm module to generate TypeScript definitions. We now strip relaxed SIMD features from the temporary Wasm module before it is executed in Node.js. This ensures that TS generation remains functional even when the project uses relaxed SIMD.
kripken
reviewed
Feb 12, 2026
| if settings.MEMORY64: | ||
| settings.MEMORY64 = 2 | ||
| # Source maps haven't been generated yet and aren't needed to run embind_gen. | ||
| settings.LOAD_SOURCE_MAP = 0 |
Collaborator
There was a problem hiding this comment.
possibly unrelated, but I was also getting error messages about source maps in here which I was able to resolve with settings.GENERATE_SOURCE_MAP = 0 here. Does it make sense to add this? If yes, in this PR or in a separate one?
Collaborator
Author
There was a problem hiding this comment.
Separate PR would be good.
sbc100
reviewed
Feb 12, 2026
sbc100
reviewed
Feb 12, 2026
sbc100
reviewed
Feb 12, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Older versions of Node.js do not support relaxed SIMD instructions, which causes errors when running the Wasm module to generate TypeScript definitions.
We now strip relaxed SIMD features from the temporary Wasm module before it is executed in Node.js. This ensures that TS generation remains functional even when the project uses relaxed SIMD.