Skip to content

Remove MainLoop.method. NFC #26254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbc100 merged 1 commit into from
Feb 13, 2026
+4 −10
Merged

Remove MainLoop.method. NFC #26254

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 4 additions & 10 deletions src/lib/libeventloop.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,6 @@ LibraryJSEventLoop = {
$MainLoop: {
running: false,
scheduler: null,
method: '',
// Each main loop is numbered with a ID in sequence order. Only one main
// loop can run at a time. This variable stores the ordinal number of the
// main loop that is currently allowed to run. All previous main loops
Expand Down Expand Up @@ -333,12 +332,10 @@ LibraryJSEventLoop = {
var timeUntilNextTick = Math.max(0, MainLoop.tickStartTime + value - _emscripten_get_now())|0;
setTimeout(MainLoop.runner, timeUntilNextTick); // doing this each time means that on exception, we stop
};
MainLoop.method = 'timeout';
} else if (mode == {{{ cDefs.EM_TIMING_RAF }}}) {
MainLoop.scheduler = function MainLoop_scheduler_rAF() {
MainLoop.requestAnimationFrame(MainLoop.runner);
};
MainLoop.method = 'rAF';
} else {
#if ASSERTIONS
assert(mode == {{{ cDefs.EM_TIMING_SETIMMEDIATE}}});
Expand Down Expand Up @@ -373,7 +370,6 @@ LibraryJSEventLoop = {
MainLoop.scheduler = function MainLoop_scheduler_setImmediate() {
MainLoop.setImmediate(MainLoop.runner);
};
MainLoop.method = 'immediate';
}
return 0;
},
Expand Down Expand Up @@ -465,14 +461,12 @@ LibraryJSEventLoop = {
return;
} else if (MainLoop.timingMode == {{{ cDefs.EM_TIMING_SETTIMEOUT }}}) {
MainLoop.tickStartTime = _emscripten_get_now();
}

#if ASSERTIONS
if (MainLoop.method === 'timeout' && Module['ctx']) {
warnOnce('Looks like you are rendering without using requestAnimationFrame for the main loop. You should use 0 for the frame rate in emscripten_set_main_loop in order to use requestAnimationFrame, as that can greatly improve your frame rates!');
MainLoop.method = ''; // just warn once per call to set main loop
}
if (Module['ctx']) {
warnOnce('Looks like you are rendering without using requestAnimationFrame for the main loop. You should use 0 for the frame rate in emscripten_set_main_loop in order to use requestAnimationFrame, as that can greatly improve your frame rates!');
}
#endif
}
Copy link
Member

@kripken kripken Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks wrong - now the warning only happens for timingMode = SETTIMEOUT?

Copy link
Collaborator Author

@sbc100 sbc100 Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, but that was true before this change too.

Before: check MainLoop.method === 'timeout'
After: check MainLoop.timingMode == EM_TIMING_SETTIMEOUT

But these checks are the same thing since method is only set to timeout then timeingMode is EM_TIMING_SETTIMEOUT

Copy link
Member

@kripken kripken Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, right, now I see.


MainLoop.runIter(iterFunc);

Expand Down