Remove Module assignments from MainLoop__postset. NFC
#26250
+50
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead these extra module methods (which are undocumented and untested) can now be exported like any other runtime method.
sbc100
force-pushed
the
MainLoop__postset
branch
from
0eb59f6 to
1a1ad7f
Compare
Collaborator
Author
|
We could alternatively simply remove these? |
kripken
approved these changes
Feb 12, 2026
Member
|
Keeping them as an option seems better to me, as the PR does. |
Collaborator
Author
|
Hmm.. actually it looks like using |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead these extra module methods (which are undocumented and untested) can now be exported like any other runtime method.