Remove remaining launcher files from git. NFC #26247
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbc100
force-pushed
the
remove_luanchers
branch
from
fd691e6 to
842e43b
Compare
Member
|
Perhaps we can document this first? I am imagining a user that hasn't updated in the last 6 months, and updates, and all the scripts are gone. They might check the README and the changelog, so perhaps it is worth updating both? |
Folks who use git need to run `./bootstrap` to have these launchers created. This has been true now since emscripten-core#23761. However, I initially left these commonly used launchers checked in so that folks could run them and they would report the "you need to run `bootstrap` message". Now that its been 6 months we removed the launcher I think existing users should all now be aware of the `./bootstrap` script. I'm also hoping to move to `.exe` files on windows soon, and this change will help smooth the way: emscripten-core#24858
sbc100
force-pushed
the
remove_luanchers
branch
from
842e43b to
cfaeb74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Folks who use git need to run
./bootstrapto have these launchers created.This has been true now since #23761.
However, I initially left these commonly used launchers checked in so that
folks could run them and they would report the "you need to run
bootstrapmessage".
Now that its been 6 months we removed the launcher I think existing
users should all now be aware of the
./bootstrapscript. I'm alsohoping to move to
.exefiles on windows soon, and this change willhelp smooth the way: #24858