Skip to content

Add test for setting CMAKE_EXECUTABLE_SUFFIX from the command line #26244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sbc100 wants to merge 1 commit into
base: main
Choose a base branch
from
+11 −0
Open

Add test for setting CMAKE_EXECUTABLE_SUFFIX from the command line #26244

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions test/test_other.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,6 +960,17 @@ def test_cmake(self, test_dir, output_file, cmake_args):
if test_dir == 'post_build':
ret = self.run_process(['ctest'], env=env)

def test_cmake_executable_suffix(self):
# Setting CMAKE_EXECUTABLE_SUFFIX for some reason does not work from the command line.
Copy link
Member

@kripken kripken Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes it sound like the test is verifying an emscripten bug, but from your PR description this is the normal CMake behavior?

Suggested change
# Setting CMAKE_EXECUTABLE_SUFFIX for some reason does not work from the command line.
# CMake ignores CMAKE_EXECUTABLE_SUFFIX from the command line.

If it is a CMake bug perhaps link to it?

Copy link
Collaborator Author

@sbc100 sbc100 Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the discussion in #22315 it seems like it not supposed to be set by the user at all.

Copy link
Member

@kripken kripken Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sg, then maybe just remove "for some reason"?

self.run_process([EMCMAKE, 'cmake', test_file('cmake/hello'), '-DCMAKE_EXECUTABLE_SUFFIX=.html'])
self.run_process(['cmake', '--build', '.'])
self.assertNotExists('hello.html')

# Bet setting CMAKE_EXECUTABLE_SUFFIX_<LANG> does:
self.run_process([EMCMAKE, 'cmake', test_file('cmake/hello'), '-DCMAKE_EXECUTABLE_SUFFIX_C=.html'])
self.run_process(['cmake', '--build', '.'])
self.assertExists('hello.html')

# Test that the various CMAKE_xxx_COMPILE_FEATURES that are advertised for the Emscripten
# toolchain match with the actual language features that Clang supports.
# If we update LLVM version and this test fails, copy over the new advertised features from Clang
Expand Down