Skip to content

Reject module promise if WebAssembly.instantiate() errors out #26215

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
aiusepsi wants to merge 1 commit into
base: main
Choose a base branch
from
+6 −2
Open

Reject module promise if WebAssembly.instantiate() errors out #26215

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/postamble_minimal.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,12 +307,16 @@ null;

}

#if WASM == 2
#if WASM == 2 || MODULARIZE
, (error) => {
#if ASSERTIONS
console.error(error);
#endif

#if MODULARIZE
readyPromiseReject?.(error);
#endif

#if ENVIRONMENT_MAY_BE_NODE || ENVIRONMENT_MAY_BE_SHELL
if (globalThis.location) {
#endif
Expand All @@ -325,7 +329,7 @@ null;
}
#endif
}
#endif // WASM == 2
#endif // WASM == 2 || MODULARIZE
Copy link
Collaborator

@sbc100 sbc100 Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the rest of this error block (the stuff relating toe location should probably not be enabled when you build with MODULARIZE?

);

#if PTHREADS || WASM_WORKERS
Expand Down