Skip to content

Only set CMAKE_EXECUTABLE_SUFFIX in toolchain if not defined already #22315

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
starball5 wants to merge 2 commits into from
+3 −1
Closed

Only set CMAKE_EXECUTABLE_SUFFIX in toolchain if not defined already #22315

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
041954e
Only set CMAKE_EXECUTABLE_SUFFIX in toolchain if not defined already
starball5 Aug 2, 2024
1f63641
Merge remote-tracking branch 'upstream/main' into patch-1
sbc100 Feb 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion cmake/Modules/Platform/Emscripten.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,9 @@ if (EMSCRIPTEN_GENERATE_BITCODE_STATIC_LIBRARIES)
message(FATAL_ERROR "EMSCRIPTEN_GENERATE_BITCODE_STATIC_LIBRARIES is not compatible with the llvm backend")
endif()

set(CMAKE_EXECUTABLE_SUFFIX ".js")
if(NOT DEFINED CMAKE_EXECUTABLE_SUFFIX)
set(CMAKE_EXECUTABLE_SUFFIX ".js")
Copy link

@bradking bradking Feb 11, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if(NOT DEFINED CMAKE_EXECUTABLE_SUFFIX) may never be true because CMake's Modules/CMakeGenericSystem.cmake always sets a default empty value earlier. Therefore this change may regress the existing default.

endif()

set(CMAKE_C_USE_RESPONSE_FILE_FOR_LIBRARIES 1)
set(CMAKE_CXX_USE_RESPONSE_FILE_FOR_LIBRARIES 1)
Expand Down