feat(instrumentation-react-native-navigation): Adding new instrumentation library to track navigation changes for React Native apps #17
+47,228
−27,071
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facostaembrace
force-pushed
the
instrumentation-react-native-navigation
branch
from
42ac15b to
cc3c154
Compare
facostaembrace
changed the title
facostaembrace
force-pushed
the
instrumentation-react-native-navigation
branch
from
cc3c154 to
f71bc35
Compare
…ion library to track navigation for React Native apps
… for attributes + cleaning up tests
…adding comments + renaming spanCreator file
facostaembrace
force-pushed
the
instrumentation-react-native-navigation
branch
from
31f5acc to
eea8205
Compare
…too long, linter fails)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Couple of months ago my team (Embrace) and I were looking for an instrumentation library that creates telemetry data on react-native applications but we noticed there was nothing ready to be used through the list instrumentation libraries following the open source standards. We also noticed people in Stack Overflow was asking about something similar.
This instrumentation library expose two components that can be implemented at the root of React Native applications and will create telemetry data that tracks navigation changes for the most popular ways of handling navigation in such environment.
Short description of the changes
<NativeNavigationTracker />that creates spans and track navigation changes forwix/react-native-navigationlibrary, and<NavigationTracker />that is meant to be used when the application handles the navigation using@react-navigation/nativeorexpo-router.