Tell rollup to cleanup the dev/prod spit from @glimmer/debug#21386
Conversation
📊 Size reportTarball size — dist/dev -1.2%↓
dist/prod -1.47%↓
smoke-tests/v2-app-hello-world-template/dist -3.31%↓
🤖 This report was automatically generated by wyvox/pkg-size |
| let entries = getRenamedModules(); | ||
| let result = await findShakenFiles(entries, prodResolve); | ||
|
|
||
| expect(result.shaken).toMatchInlineSnapshot(` |
There was a problem hiding this comment.
declaring our low-level modules as shakable has a cascade of improvements (which we'll see the fruits of in a future PR)
|
I'm seeing browserstack stuck across 5 separate PRs... so... I guess they did something over there... |
| onLog: handleRollupWarnings, | ||
| input, | ||
| treeshake: { | ||
| moduleSideEffects(id) { |
There was a problem hiding this comment.
I feel like very few of our modules actually have side effects and wonder if we can't invert this and only list the things that do have side effects, rather than listing some things that don't.
There was a problem hiding this comment.
yea, I'll experiment with that next -- would be good information to have ahead of #21365
the "side-effects tests" we have also flag rollup's "hoisted imports", which is kind of annoying, but something I also need to look in to
Extracted from https://github.com/emberjs/ember.js/pull/21365/changes