Drop isInteractive and hasDOM; remove FastBoot codepaths#21347
Closed
NullVoxPopuli-ai-agent wants to merge 2 commits into
Closed
Drop isInteractive and hasDOM; remove FastBoot codepaths#21347NullVoxPopuli-ai-agent wants to merge 2 commits into
NullVoxPopuli-ai-agent wants to merge 2 commits into
Conversation
Since we always have a DOM and modifiers always run, the entire isInteractive/hasDOM split is dead weight. Tear it out. Glimmer-vm: - @glimmer/runtime/lib/environment.ts: drop the isInteractive field on EnvironmentImpl and EnvironmentDelegate. scheduleInstallModifier and scheduleUpdateModifier always schedule. - @glimmer/runtime/lib/compiled/opcodes/dom.ts: drop the early-returns in VM_MODIFIER_OP and VM_DYNAMIC_MODIFIER_OP. Modifiers always run. - @glimmer/interfaces: drop isInteractive from the Environment interface. Ember component layer: - curly + root component managers: lifecycle hooks (willRender, willInsertElement, didInsertElement, willUpdate, didUpdate, didRender, willDestroyElement, willClearRender) always fire. - ComponentStateBucket no longer carries isInteractive. - BootEnvironment loses both fields. Renderer: - BaseRenderer / Renderer / renderComponent no longer take an env config. isInteractive and hasDOM options are gone. - Renderer.getElement always returns the element (no more "not allowed in non-interactive environments" throw). - Renderer.remove always triggers didDestroyElement. - Drop the _isInteractive getter and the debug.isInteractive field. - EmberEnvironmentDelegate has no constructor args. Application/engine boot: - BootOptions drops isInteractive and isBrowser. - _BootOptions no longer threads isInteractive through isBrowser / shouldRender / option override; just _renderMode, location, shouldRender, document, rootElement. - ApplicationInstance always calls setupEventDispatcher. - EngineInstance's singleton list always includes event_dispatcher:main. - EventDispatcher.setup drops the "should never be setup in fastboot" assertion. - @ember/-internals/views/lib/system/event_dispatcher.ts no longer imports from @ember/-internals/glimmer. Component: - The DEBUG tagless event-handler check no longer needs renderer._isInteractive. - _dispatcher always looks up event_dispatcher:main. - appendTo always uses document.querySelector for string selectors; the "no DOM" branch is gone. matches() drops its fastboot guard. Browser-environment package: deleted entirely. - isChrome/isFirefox were the only remaining consumers (in @ember/debug); inlined there with `typeof window !== 'undefined'` guards. - self/location/history/window references were the only hasDOM users. - Removed from @ember/-internals package exports, root package.json embedded-package map, types/stable manifest, and lib/index.js implicit-modules list. - Test files that imported `window`/`isChrome`/`isFirefox` from browser-environment now use globals directly. Inputs lazily initialize INPUT_ELEMENT (instead of at module-load time) so node-side build tooling that imports the package without a DOM in scope still loads. The DOM is required at render time, which is the contract. Tests: - Drop the non-interactive variants of the lifecycle, custom-modifier, and on-modifier integration tests. Drop the lifecycle test's isInteractive/nonInteractive split — assertHooks always uses the interactive expectations. - Drop the visit_test that checked event_dispatcher:main wasn't created for isInteractive: false. - OutletView render-queue test now appends to a real DOM element rather than a CSS-selector string (since selector resolution is no longer short-circuited). - type-tests for BootOptions no longer mention isBrowser. Smoke tests: - Delete app-boot, component-rendering, fastboot-sandbox, and visit tests in node-template, plus their setup-app/setup-component/build-owner/ assert-html-matches helpers. They were FastBoot-only — every one of them used SimpleDOM as a stand-in for `document`. Cumulative diff vs nvp/environment-collapse: 44 files, +163 / -1746. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Contributor
|
Prompter's note:
|
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on top of #21346.
Since we always have a DOM and modifiers always run, the entire
isInteractive/hasDOMsplit is dead weight.Summary
isInteractivefromEnvironmentImpl/EnvironmentDelegate/Environment.scheduleInstallModifier,scheduleUpdateModifier,VM_MODIFIER_OP, andVM_DYNAMIC_MODIFIER_OPalways run.willRender,willInsertElement,didInsertElement,willUpdate,didUpdate,didRender,willDestroyElement,willClearRender) always fire.isInteractive/hasDOMfrom boot options;getElementalways returns the element;remove(view)always triggersdidDestroyElement.BootOptions.isInteractiveandBootOptions.isBrowser.setupEventDispatcheralways runs.EventDispatcher.setupno longer asserts against fastboot mode.EngineInstancealways registersevent_dispatcher:main.@ember/-internals/browser-environmentdeleted entirely. The only remaining consumers wereisChrome/isFirefoxin@ember/debug— inlined withtypeof window !== 'undefined'guards.self/location/history/windowre-exports are gone.<Input>initializes its probe element lazily so build tools that import the package in Node (without a DOM in scope) still load. DOM is required at render time, which is the contract._dispatcheralways looks upevent_dispatcher:main.appendToalways usesdocument.querySelectorfor string selectors.matches()drops its fastboot guard.Tests dropped
non-interactivevariants of the lifecycle, custom-modifier, and on-modifier integration testsvisit_testfor "doesn't set up event_dispatcher:main if isInteractive is false"smoke-tests/node-template/tests/node/(app-boot, component-rendering, fastboot-sandbox, visit) and their SimpleDOM-based helpers44 files changed, +163 / -1746.
Verified
🤖 Generated with Claude Code