Make the low-level component scope able to be an object instead of an array#21224
Merged
NullVoxPopuli merged 10 commits intoemberjs:mainfrom Mar 20, 2026
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The captureRenderTree API returns a nested tree structure. Component nodes are children of other nodes, so we need to recursively flatten the tree before searching for component names. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This comment was marked as resolved.
This comment was marked as resolved.
Add tests for: - <this.dynamicComponent> invocations - <@argComponent> invocations Both currently produce '(unknown template-only component)' instead of the expected component name because dynamic resolution at runtime loses the invocation-site name information. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…RenderTree For dynamic component invocations like `<this.Foo>` and `<@Greeting>`, the debug render tree now shows the invocation-site name instead of '(unknown template-only component)'. This works by extracting the Reference's debugLabel in VM_RESOLVE_DYNAMIC_COMPONENT_OP and VM_RESOLVE_CURRIED_COMPONENT_OP, and setting it as the ComponentDefinition's debugName when no name is already present. - `<this.Foo>` → name: "Foo" - `<@Greeting>` → name: "Greeting" Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
lifeart
approved these changes
Mar 18, 2026
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The invocation-site name propagation relies on ref.debugLabel which is only available in DEBUG mode. Skip these tests in production builds. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
|
I'm actually surprised how small of a change this is to the vm code |
NullVoxPopuli
approved these changes
Mar 19, 2026
ef4
approved these changes
Mar 20, 2026
NullVoxPopuli-ai-agent
pushed a commit
to NullVoxPopuli-ai-agent/ember.js
that referenced
this pull request
Mar 23, 2026
Now that the scope bag is a `Record<string, unknown>`, the lexical symbol names are always carried alongside their values. This eliminates the need for the `lexicalSymbols` slot in the wire format block (previously only available when `debugSymbols` was enabled) and allows `meta()` to derive `lexical` names and `scopeValues` directly from the scope object's keys and values. See also: upstream PR emberjs#21224, PR emberjs#21068. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
2 tasks
NullVoxPopuli-ai-agent
pushed a commit
to NullVoxPopuli-ai-agent/ember.js
that referenced
this pull request
Mar 23, 2026
Now that the scope bag is a `Record<string, unknown>`, the lexical symbol names are always carried alongside their values. This eliminates the need for the `lexicalSymbols` slot in the wire format block (previously only available when `debugSymbols` was enabled) and allows `meta()` to derive `lexical` names and `scopeValues` directly from the scope object's keys and values. See also: upstream PR emberjs#21224, PR emberjs#21068. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NullVoxPopuli-ai-agent
pushed a commit
to NullVoxPopuli-ai-agent/ember.js
that referenced
this pull request
Mar 23, 2026
Now that the scope bag is a `Record<string, unknown>`, the lexical symbol names are always carried alongside their values. This eliminates the need for the `lexicalSymbols` slot in the wire format block (previously only available when `debugSymbols` was enabled) and allows `meta()` to derive `lexical` names and `scopeValues` directly from the scope object's keys and values. See also: upstream PR emberjs#21224, PR emberjs#21068. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
NullVoxPopuli-ai-agent
pushed a commit
to NullVoxPopuli-ai-agent/ember.js
that referenced
this pull request
Mar 23, 2026
Now that the scope bag is a `Record<string, unknown>`, the lexical symbol names are always carried alongside their values. This eliminates the need for the `lexicalSymbols` slot in the wire format block (previously only available when `debugSymbols` was enabled) and allows `meta()` to derive `lexical` names and `scopeValues` directly from the scope object's keys and values. See also: upstream PR emberjs#21224, PR emberjs#21068. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes
good luck lil'bot
description from over there:
This was really bothering me when I was trying to debug my typedoc renderer
I need to build this ember and test it in that project before starting review.
As part of debugging this, I think I need a button on the inspector to just show the debugRenderTree node
Before
note for me http://localhost:4201/Runtime/util/page-nav
the failing test result in the first commit:
there is also a failing smoke test so we can e2e the whole setup:
this also fails
After
from my actual app with recursive type/typedoc rendering: