Merged
Conversation
NullVoxPopuli
changed the title
kategengler
reviewed
Mar 3, 2026
Contributor
📊 Package size report -0%↓
🤖 This report was automatically generated by pkg-size-action |
NullVoxPopuli
force-pushed
the
nvp/migrate-node-tests-to-scenarios
branch
from
eff8636 to
f8106ef
Compare
kategengler
reviewed
Mar 4, 2026
| "scripts": { | ||
| "test:node": "qunit tests/node/**/*-test.js" | ||
| }, | ||
| "dependencies": { |
Member
There was a problem hiding this comment.
Can any deps move out of the main package.json?
Contributor
Author
There was a problem hiding this comment.
and then linked via scenario? or?
Member
There was a problem hiding this comment.
Just thought there might be test-only deps able to be moved into this package.json from the root
Contributor
Author
There was a problem hiding this comment.
oh I see -- i'll check
kategengler
reviewed
Mar 4, 2026
| @@ -244,6 +245,7 @@ export default [ | |||
| '**/babel.test.config.mjs', | |||
| 'node-tests/**/*.js', | |||
| 'tests/node/**/*.js', | |||
Member
There was a problem hiding this comment.
Prob the tests/node lines can drop?
Contributor
Author
There was a problem hiding this comment.
We have a utils test (the buildinfo) still in there --- it tests are infra rather than the behavior of ember-source, so I guess it still makes sense to have there -- your earlier gut feeling was good
kategengler
previously approved these changes
Mar 4, 2026
Update dependencies in smoke test node template ope Move build-info-test back to tests/node/ build-info-test tests build infrastructure (broccoli/build-info), not node support. It can't run as a smoke test because broccoli/ is not in the published package's files list. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Restore commented-out code in overrides-test.js Keeps the PR diff minimal by not removing comments that were already present in the original file. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> update eslint
…ed in node-template
NullVoxPopuli
force-pushed
the
nvp/migrate-node-tests-to-scenarios
branch
from
0e58601 to
29a1320
Compare
kategengler
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows us to: