-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
Remove '@ember/application's lazy load / onLoad stuff (private API) #21056
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Estimated Asset SizesDiff --- main/out.txt 2026-01-16 20:37:26.000000000 +0000
+++ pr/./pr-21087587728/out.txt 2026-01-17 03:20:12.000000000 +0000
@@ -1,16 +1,16 @@
-╔═══════╤══════════╤══════════╗
-║ │ Min │ Gzip ║
-╟───────┼──────────┼──────────╢
-║ Total │ 352.2 KB │ 203.5 KB ║
-╚═══════╧══════════╧══════════╝
+╔═══════╤═══════════╤══════════╗
+║ │ Min │ Gzip ║
+╟───────┼───────────┼──────────╢
+║ Total │ 351.43 KB │ 202.8 KB ║
+╚═══════╧═══════════╧══════════╝
╔══════════════════════╤═══════════╤═══════════╗
║ @ember/* │ Min │ Gzip ║
╟──────────────────────┼───────────┼───────────╢
-║ Total │ 313.81 KB │ 181.76 KB ║
+║ Total │ 313.05 KB │ 181.06 KB ║
╟──────────────────────┼───────────┼───────────╢
║ -internals │ 36.61 KB │ 25.99 KB ║
-║ application │ 13.24 KB │ 7.99 KB ║
+║ application │ 12.47 KB │ 7.29 KB ║
║ array │ 13.05 KB │ 7.54 KB ║
║ canary-features │ 304 B │ 419 B ║
║ component │ 2.05 KB │ 1.61 KB ║Details
|
|
This was quite a long time ago and we never deprecated the old style of testing, afaik. BUT, I suspect it does not work at all in even 6.0 or earlier. I think we should see what, if anything of ember-testing is still in use at 6.0.
Overall, I think this looks good but I wonder if we should land it with 7.0 just to be safe. |
Removes
@ember/application/lib/lazy_loadonLoad, private_loaded, implicit private (internal)runLoadHooks, privateember-testing/lib/initializersonLoadfrom@ember/application/lib/lazy_loadonLoadis removedOther things I found:
Test.registerHelperis a thing -- why? (before we had async testing? or ESM?)advanceReadinessis a public api and still hav a fair number of tests covering its usageAccording to the size comment, this PR removes 0.8KB
local bench: