Skip to content

Restore Ember addon identity to @ember/string v4#480

Draft
Copilot wants to merge 2 commits intomainfrom
copilot/apply-string-patch-comment-447
Draft

Restore Ember addon identity to @ember/string v4#480
Copilot wants to merge 2 commits intomainfrom
copilot/apply-string-patch-comment-447

Conversation

Copy link

Copilot AI commented Mar 11, 2026

@ember/string v4 was published as a plain npm package, stripping its Ember addon identity. This broke Embroider's v1-addon compatibility layer, which requires the ember-addon keyword to make the module resolvable from v1 addons that don't explicitly declare @ember/string as a dependency.

Changes

  • addon-main.cjs — new file; minimal v2 addon entry point required by Embroider
  • package.json
    • Add "keywords": ["ember-addon"] — signals Embroider to apply addon resolution compatibility
    • Add "ember-addon" metadata block registering the package as a v2 addon with an empty app-js map

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Co-authored-by: NullVoxPopuli <199018+NullVoxPopuli@users.noreply.github.com>
Copilot AI changed the title [WIP] Apply patch from issue comment 447 Restore Ember addon identity to @ember/string v4 Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants