Source to source mode #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default, consumers will get either the node or browser implementation automatically based on their environment. Since these implementations support slightly different options, consumers that want to be portable themselves may want to pick one implementation (probably the browser one, since it is the more portable) and stick to it, regardless of their own environment. This change enables that by allowing direct imports of `babel-plugin-ember-template-compilation/browser` and `babel-plugin-ember-template-compilation/node`, both of which bypass the automatic environment switching.
allow direct access to browser and node implementations
Not just the precompile function.
Contributor
Author
|
Tagged and published v2.0.0-alpha.0 off this branch. |
Contributor
Author
|
I'm going to merge this and the other pending work so that we can better coordinate what will be babel-plugin-ember-template-compilation 2.0.0-beta series. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for running AST transforms without doing the full compilation, in the same way that Embroider does in stage1.
This would replace the need for that, and by unifying the implementations means that we'll get consistent handling of features like lexical scope even as we introduce ast transforms that can manipulate JS scope.
This also makes the AST transforms a first-class option. Classically, implementations have always wrapped ember's precompile function in a closure that provides the transform plugins, but there's no need to do that.
This is a breaking change because I changed the options format, because instead of only needing the ember template compiler's
precompilefunction we now use the whole ember template compiler module.it.todotests