Fix ASI not firing before <template> in class bodies#19
Open
andsmedeiros wants to merge 1 commit into
Open
Conversation
Member
|
looks like tests are failing :( |
Author
|
The issue is actually a version incompatibility between The action version used in this repository is too old to be used with recent |
Member
def -- just wasn't expecting surprise maintenance 🙈 |
3 tasks
Member
|
Just needs rebase now |
The upstream JS scanner suppresses automatic semicolon insertion before `<` because in standard JS it could be a less-than operator. In GJS/GTS, `<template>` is a valid class body member, which caused field definitions without a trailing semicolon to not be recognised when followed by a template tag. Fix this in scanner.c by intercepting the AUTOMATIC_SEMICOLON case before delegating to the JS scanner. We call scan_automatic_semicolon directly (accessible from the included scanner.h), and when it refuses due to `<`, we peek ahead for `template>` and emit the semicolon ourselves. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream JS scanner suppresses automatic semicolon insertion before
<because in standard JS it could be a less-than operator. In GJS/GTS,<template>is a valid class body member, which caused field definitions without a trailing semicolon to not be recognised when followed by a template tag.Fix this in scanner.c by intercepting the AUTOMATIC_SEMICOLON case before delegating to the JS scanner. We call scan_automatic_semicolon directly (accessible from the included scanner.h), and when it refuses due to
<, we peek ahead fortemplate>and emit the semicolon ourselves.