Closed
Conversation
Gaurav0
force-pushed
the
upgrade_base
branch
13 times, most recently
from
f536bcc to
88a1221
Compare
do not auto install peer dependencies
When running against Ember 4.4 our CI was failing, because ember-cli-babel incorrectly gets confused about which actual ember-source is in use. --- Without this change, the various ember-cli-babel processes were identifying that ember-source@3.26 was in use and was therefore transpiling all `@ember/***` module usage to `Ember` global usage. This is "fine" for Ember 3.26, but under 3.27+ "real" modules exist and globals rewriting is no longer needed.
explicitly add @ember/test-helpers to devDependencies in test-packages
Gaurav0
force-pushed
the
upgrade_base
branch
2 times, most recently
from
ced999a to
eb33984
Compare
| "node": "16.18.1", | ||
| "yarn": "1.22.19" | ||
| "yarn": "1.22.19", | ||
| "pnpm": "7.33.5" |
Contributor
There was a problem hiding this comment.
Why an old version of pnpm?
Contributor
Author
There was a problem hiding this comment.
That's the version currently in ci. I figured updating it should be separate.
Contributor
NullVoxPopuli
left a comment
NullVoxPopuli
left a comment
There was a problem hiding this comment.
Can the switch to/from pnpm be separated from blueprintesque changes?
Seems like there are a few things happening in here, and it'd be better for the changelog to have them separated, not just for the changelog tho, but managing the realm of potential debug-points during a git bisect.
Thanks!
Contributor
Author
|
@NullVoxPopuli Fastboot is already using pnpm 7. Maybe some of the fixes might be independently added, but one of the primary problems in ci right now is using old versions of ember-source. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an update of #916
Unlike that PR, the scope is reduced to:
It does not:
These will be addressed in separate PRs so that this one is easier to review.
Remaining failing tests:
All other tests are passing.
Also, I've taken care to make smaller commits and to clean them up. Hopefully it is easy to review commit by commit.