Conversation
|
Blocked by tomdale/ember-cli-addon-tests#198 and Workarounds:
|
|
@Turbo87 @stefanpenner @rwjblue This is green now, can you review? |
| pkg.devDependencies['ember-cli-fastboot'] = '*'; | ||
| // These 2 are in ember-fetch's package.json, symlinking to dummy won't help resolve | ||
| pkg.devDependencies['abortcontroller-polyfill'] = '*'; | ||
| pkg.devDependencies['node-fetch'] = '*'; |
There was a problem hiding this comment.
I'm not sure I understand. Why are these needed?
There was a problem hiding this comment.
See this PR, Fastboot.requrie is reading from node_modules/node-fetch but it's under node_modules/ember-fetch/node-fetch when symlink.
test/fastboot-test.js
Outdated
|
|
||
| let app; | ||
|
|
||
| before(function() { |
There was a problem hiding this comment.
this should use beforeEach() so that the tests can't leak state
test/fastboot-build-test.js
Outdated
|
|
||
| let app; | ||
|
|
||
| before(function() { |
There was a problem hiding this comment.
this should use beforeEach() so that the tests can't leak state
|
|
||
| loadInitializers(App, config.modulePrefix); | ||
|
|
||
| export default App; |
There was a problem hiding this comment.
where are these fixture files being used?
There was a problem hiding this comment.
These are used by ember-cli-addon-tests to copy over generated new app. It's same setup as https://github.com/ember-fastboot/ember-cli-fastboot/tree/master/test
xg-wang
force-pushed
the
fastboot
branch
3 times, most recently
from
fcf0c9a to
cef993a
Compare
use npm run instead of yarn in travis to work around tomdale/ember-cli-addon-tests#198
| - yarn lint:js | ||
| - yarn test | ||
| - yarn test:node | ||
| - npm run test:node |
There was a problem hiding this comment.
This is a known issue tomdale/ember-cli-addon-tests#198, should be fixed by a WIP PR tomdale/ember-cli-addon-tests#105
3 participants
Introduce ember-cli-addon-tests to test:
ember-cli-fastboothasdist/ember-fetch/fastboot-fetch.jsbuiltember-cli-fastbootrenders fetched content