Change authentication priority #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `api_key` or `access_token` passed into a request will take priority over the globally configured API key.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the authentication behavior so that the API key (or access token) provided at request time takes precedence over the globally configured API key.
- Added a new test to ensure request-time API key authentication overrides the global configuration.
- Modified the client to check the request time parameters first, then fallback to the global API key.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/authentication_test.rb | Added a test to confirm authentication priority. |
| lib/emailable/client.rb | Adjusted the token lookup order to prioritize request parameters. |
Comments suppressed due to low confidence (1)
test/authentication_test.rb:28
- Consider adding an additional test case to verify that a request-time access_token also takes priority over the global API key.
Emailable.api_key = 'invalid_api_key'
danarnold
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
api_keyoraccess_tokenpassed into a request will take priority over the globally configured API key.