Skip to content

Conversation

@jclusso
Copy link
Member

@jclusso jclusso commented May 21, 2025

  • Added ability to specify api_key or access_token at request time
  • Changed authentication credentials to always be passed in headers
  • Removed pry, added amazing_print, and fixed require order for active_model.
  • Updated CI

- Added ability to specify `api_key` or `access_token` at request time
- Changed authentication credentials to always be passed in headers
- Removed `pry`, added `amazing_print`, and fixed require order for `active_model`.
- Updated CI and fixed RuboCop violations
@jclusso jclusso force-pushed the add-access-token-auth branch from 5736790 to 6cbbdf8 Compare May 21, 2025 22:49
danarnold and others added 2 commits May 27, 2025 12:13
…est mixing positional and keyword arguments with implicit hash conversion. update the project's ruby to 3.4.4 (latest).
Fix keyword argument incompatibility
@jclusso jclusso requested a review from danarnold May 27, 2025 16:54
jclusso added 2 commits May 29, 2025 08:40
…e-ruby into add-access-token-auth

* 'add-access-token-auth' of github.com:emailable/emailable-ruby:
  fix keyword argument incompatibility caused by Emailable::Client#request mixing positional and keyword arguments with implicit hash conversion. update the project's ruby to 3.4.4 (latest).
@jclusso jclusso requested a review from danarnold May 29, 2025 12:40
danarnold
danarnold previously approved these changes May 29, 2025
@jclusso jclusso merged commit 566d89a into master May 30, 2025
7 checks passed
@jclusso jclusso deleted the add-access-token-auth branch May 30, 2025 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants