-
Notifications
You must be signed in to change notification settings - Fork 4
Add support for access token authentication #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added ability to specify `api_key` or `access_token` at request time - Changed authentication credentials to always be passed in headers - Removed `pry`, added `amazing_print`, and fixed require order for `active_model`. - Updated CI and fixed RuboCop violations
5736790 to
6cbbdf8
Compare
…est mixing positional and keyword arguments with implicit hash conversion. update the project's ruby to 3.4.4 (latest).
Fix keyword argument incompatibility
danarnold
reviewed
May 29, 2025
danarnold
reviewed
May 29, 2025
…e-ruby into add-access-token-auth * 'add-access-token-auth' of github.com:emailable/emailable-ruby: fix keyword argument incompatibility caused by Emailable::Client#request mixing positional and keyword arguments with implicit hash conversion. update the project's ruby to 3.4.4 (latest).
danarnold
previously approved these changes
May 29, 2025
danarnold
approved these changes
May 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
api_keyoraccess_tokenat request timepry, addedamazing_print, and fixed require order foractive_model.