fix: only response with html if client prefers media type #1271
+44
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous implemtantion has quite basic and didn't account for the q parameter a client can add to an entry in the accept header. This would fail with HTTPie, which send requests with "Accept: application/json, text/*;q=0.5". While one can argument that responding with HTML is in spec, it isn't a good DX.
josevalim
reviewed
May 30, 2025
josevalim
reviewed
May 30, 2025
Member
|
💚 💙 💜 💛 ❤️ |
josevalim
added a commit
that referenced
this pull request
Jul 1, 2025
This was causing markdown to be rendered in at least Safari. This reverts commit 57d04d7.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous implemtantion has quite basic and didn't account for the q parameter a client can add to an entry in the accept header.
This would fail with HTTPie, which send requests with "Accept: application/json, text/*;q=0.5". While one can argument that responding with HTML is in spec, it isn't a good DX.