Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions nx/lib/nx.ex
Original file line number Diff line number Diff line change
Expand Up @@ -14594,6 +14594,9 @@ defmodule Nx do

iex> Nx.gather(Nx.tensor([[1, 2], [3, 4]]), Nx.tensor([[0, 0]], type: :f32))
** (ArgumentError) indices must be an integer tensor, got {:f, 32}

iex> Nx.gather(Nx.iota({3}), Nx.tensor(0))
** (ArgumentError) expected indices rank to be at least 1, got: 0
"""
@doc type: :indexed
def gather(tensor, indices, opts \\ []) do
Expand All @@ -14602,6 +14605,10 @@ defmodule Nx do
[%T{vectorized_axes: vectorized_axes} = tensor, indices] =
broadcast_vectors([tensor, indices], align_ranks: false)

if indices.shape == {} do
raise ArgumentError, "expected indices rank to be at least 1, got: 0"
end

axes = indexed_axes(tensor, indices, opts)

unless Nx.Type.integer?(indices.type) do
Expand Down
6 changes: 6 additions & 0 deletions nx/test/nx_test.exs
Original file line number Diff line number Diff line change
Expand Up @@ -2863,6 +2863,12 @@ defmodule NxTest do
Nx.gather(t, Nx.tensor([[0, -1]]))
end
end

test "raises correct error on scalar indices" do
assert_raise ArgumentError, ~r/expected indices rank to be at least 1/, fn ->
Nx.gather(Nx.iota({3}), Nx.tensor(0))
end
end
end

describe "variance/1" do
Expand Down
Loading