Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the MPNet model family, enabling models like
sentence-transformers/all-mpnet-base-v2to be used in Bumblebee.I noticed there was a previous attempt at this in #405 by @snewcomer, but it seems to have gone stale. I used the feedback from that PR review (thanks @jonatanklosko!) to create this implementation.
Changes
Bumblebee.Text.Mpnetmodule with support for all standard architectures::base:for_masked_language_modeling:for_sequence_classification:for_token_classification:for_question_answering:for_multiple_choiceBumblebee.load_model/2:mpnettokenizer type with the correct special tokensNotes
token_type_ids(unlike BERT)q,k,v,oinstead ofquery,key,value,output)Closes #219