feat: configure Workspace Symbols to return all symbols on empty query #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doorgan
force-pushed
the
doorgan/configuration
branch
3 times, most recently
from
982fef7 to
34c17d9
Compare
doorgan
force-pushed
the
doorgan/configuration
branch
from
34c17d9 to
9a679fc
Compare
mhanberg
reviewed
Jan 14, 2026
| |> maybe_add_watched_extensions(settings) | ||
| new_config = | ||
| old_config | ||
| |> set_dialyzer_enabled(settings) |
Member
There was a problem hiding this comment.
I'm confused, do we support dialzyer?
Collaborator
Author
There was a problem hiding this comment.
The option was already there and I didn't remove it. Looking into the codebase we're not doing anything with it so I'll remove it altogether.
Looking at discussions from when this was still Lexical, there were some attempts to add dialyzer and there was a TODO for it: lexical-lsp/lexical#95
But it never got implemented, and this config option seems to be a leftover from that time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #140
Closes #155
There's a rather big change to the way we do configuration, not only to support this new option, but also becase there was a race condition that prevented config changes from being applied reliably, as requests other than didChangeConfiguration could be handled at the same time as eg textDocument/didOpen, which would return a state with the old config, overwriting the new one.
The new approach is to use
:persistent_terminstead. I opted for this rather than a genserver or an agent because configuration changes are infrequent, and removing the config from the server state is enough to eliminate that race condition