Merged
Conversation
We now redact headers instead of just dropping them. This allows users of the Error Tracker to know wether a header was present or not. With the previous logic it was impossible to know wether the header was dropped or not present in the first place. We also redact the `set-cookie` header so we redact outgoing cookies and not only incoming cookies as per the `cookie` header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We now redact headers instead of just dropping them. This allows users of the Error Tracker to know wether a header was present or not. With the previous logic it was impossible to know wether the header was dropped or not present in the first place.
We also redact the
set-cookieheader so we redact outgoing cookies and not only incoming cookies as per thecookieheader.This PR replaces #166