Make timeouts for TypeServer configurable #755
Merged
+6
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Th3-M4jor
force-pushed
the
make-typeserver-timeout-configurable
branch
from
893e733 to
9ca8a08
Compare
josevalim
reviewed
Nov 28, 2025
lib/postgrex/type_server.ex
Outdated
| defstruct [:types, :connections, :lock, :waiting] | ||
|
|
||
| @timeout 60_000 | ||
| @timeout Application.compile_env(:postgrex, :type_server_timeout, 60_000) |
Member
There was a problem hiding this comment.
I don't think it needs to be a compile time setting. Let's move it to runtime. Also, move the default value to the def application section in the mix.exs, this way we can use fetch_env! here. Thanks!
Contributor
Author
There was a problem hiding this comment.
Thanks for the feedback.
Th3-M4jor
force-pushed
the
make-typeserver-timeout-configurable
branch
from
9ca8a08 to
e39bac0
Compare
Member
|
💚 💙 💜 💛 ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were testing out YugabyteDB with nodes in Australia, France, and the Eastern US and found that Postgrex connections were consistently failing to startup when connecting to nodes in France or Australia if we wanted to have a pool size greater than one.
The root cause is that the bootstrap queries Postgrex makes are taking a lot longer than the 60 seconds the TypeServer allows while a connection is waiting to get the lock.
This is because the first query of a connection forces the node to cache cluster information from the leader node, which can take a long time when the leader is on the opposite side of the world.
Yugabyte has "smart" drivers that are able to work around this issue, but there isn't one in Elixir so the simplest solution would be us being able to raise this timeout to a much higher number.