Skip to content

Redact repo config from SASL progress reports (#4718) #4727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
josevalim merged 4 commits into from
May 15, 2026
+11 −1
Merged

Redact repo config from SASL progress reports (#4718) #4727

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
114b43e
Redact repo config from SASL progress reports
dl-alexandre May 15, 2026
b9cd376
Improve SensitiveData placement and add @doc false
dl-alexandre May 15, 2026
b3241e8
Move SensitiveData module to its own definition
josevalim May 15, 2026
c5a889e
Apply suggestion from @josevalim
josevalim May 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion lib/ecto/repo/supervisor.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
defmodule Ecto.Repo.SensitiveData do
@moduledoc false
@derive {Inspect, only: []}
defstruct [:data]
end

defmodule Ecto.Repo.Supervisor do
@moduledoc false
use Supervisor
Expand Down Expand Up @@ -209,6 +215,10 @@ defmodule Ecto.Repo.Supervisor do
end
end

def start_child(%Ecto.Repo.SensitiveData{data: {mod, fun, args}}, name, adapter, meta) do
start_child({mod, fun, args}, name, adapter, meta)
end

def start_child({mod, fun, args}, name, adapter, meta) do
case apply(mod, fun, args) do
{:ok, pid} ->
Expand All @@ -222,6 +232,6 @@ defmodule Ecto.Repo.Supervisor do
end

defp wrap_child_spec(%{start: start} = spec, args) do
%{spec | start: {__MODULE__, :start_child, [start | args]}}
%{spec | start: {__MODULE__, :start_child, [%Ecto.Repo.SensitiveData{data: start} | args]}}
end
end