Skip to content

fix: support pin interpolation of temporal values #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
srowley wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: support pin interpolation of temporal values #55

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions lib/dux.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2200,6 +2200,10 @@ defmodule Dux do

defp encode_param(v) when is_integer(v), do: Integer.to_string(v)
defp encode_param(v) when is_float(v), do: Float.to_string(v)
defp encode_param(%Date{} = v), do: "'#{Date.to_iso8601(v)}'"
defp encode_param(%Time{} = v), do: "'#{Time.to_iso8601(v)}'"
defp encode_param(%NaiveDateTime{} = v), do: "'#{NaiveDateTime.to_iso8601(v)}'"
defp encode_param(%DateTime{} = v), do: "'#{DateTime.to_iso8601(v)}'"
defp encode_param(v) when is_binary(v), do: "'#{String.replace(v, "'", "''")}'"
defp encode_param(true), do: "true"
defp encode_param(false), do: "false"
Expand Down
11 changes: 11 additions & 0 deletions test/dux/query_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,17 @@ defmodule Dux.QueryTest do
assert result["name"] == ["Alice"]
end

test "date pin" do
cutoff = ~D[2024-01-01]

result =
Dux.from_query("SELECT DATE '2023-12-30' AS d UNION ALL SELECT DATE '2024-01-02' AS d")
|> Dux.filter(d > ^cutoff)
|> Dux.to_columns()

assert result["d"] == [~D[2024-01-02]]
end

test "multiple pins" do
lo = 5
hi = 15
Expand Down
Loading