[codex] fix temporal values from from_list#54
Merged
Conversation
Contributor
|
Thanks! I am starting to get a little more familiar with the library and noticed that pin interpolation doesn't support temporal values. I wrote a fix and a test for that. The test passes after the fix and my uses for that functionality now work, but I can't run the entire test suite without getting a bunch of out-of-memory errors. If you'd like me to submit a pull request with that I'm happy to; I just can't guarantee it didn't break something else. Edit - I figured out how to run tests; pull request forthcoming. Also a separate PR for consideration that fixed the tests for me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Date,Time,NaiveDateTime, andDateTimestructs as typed DuckDB literals in the small-listfrom_list/1SQL path.Root Cause
Small list sources are represented as inline
SELECT ... UNION ALL ...SQL, butDux.QueryBuilder.encode_value/1only handled nil, numbers, booleans, and strings. Temporal structs therefore raised aFunctionClauseErrorbefore DuckDB could evaluate the query. Large lists already used ADBC ingestion and did not hit this encoder.Validation
mix test test/dux/verb_test.exsDux.peek/1on the example from the issueFixes #51