perf: flat SQL for single-op pipelines and group_by+summarise#50
Merged
Merged
Conversation
Three QueryBuilder optimizations: 1. Single-op pipelines emit flat SQL without CTE wrapping 2. group_by+summarise pattern emits a single SELECT...GROUP BY 3. Table sources referenced directly by name instead of subquery
Contributor
|
Hey @hugobarauna thank you for this. Looks like a pretty straightforward win! Crazy few days over here but I'll have a proper look Monday. |
Contributor
|
Thank you! <3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip CTE wrapping for common pipeline shapes:
filterormutatealone) emit flat SQL instead ofWITH __s0 AS (...) SELECT * FROM __s0group_by + summarise(the most common aggregation) emits a singleSELECT ... GROUP BYwithout CTEs(SELECT * FROM "table") __srcBenchmark (1M rows, Apple M2 Pro, Benchee)
Benchmark script: https://gist.github.com/hugobarauna/369f68acf4292f27309782ba774b8988
Example
Before:
After: