Skip to content

Make file writable before applying strip #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dominicletz wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make file writable before applying strip #12

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 11 additions & 5 deletions lib/tooling.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,11 +76,17 @@ defmodule Desktop.Deployment.Tooling do
is_binary = extname == ""
is_library = Regex.match?(~r/\.(so|dylib|smp)($|\.)/, extname)

cond do
os() == MacOS and is_library -> cmd!("strip", ["-x", "-S", file])
os() == MacOS and is_binary -> cmd!("strip", ["-u", "-r", file])
is_binary || is_library -> cmd!("strip", ["-s", file])
true -> :ok
strip_args =
cond do
os() == MacOS and is_library -> ["-x", "-S"]
os() == MacOS and is_binary -> ["-u", "-r"]
is_binary || is_library -> ["-s"]
true -> nil
end

if strip_args do
File.chmod!(file, Bitwise.bor(File.lstat!(file).mode, 0o200))
cmd!("strip", strip_args ++ [file])
end

file
Expand Down
Loading