Skip to content

docs: Add ClickHouse as compatible with query_id in dbt_run_results #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
29antonioac wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: Add ClickHouse as compatible with query_id in dbt_run_results #1004

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion models/run_results.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -214,7 +214,7 @@ models:

- name: query_id
data_type: string
description: Query ID in the data warehouse, if returned by the adapter (currently only supported in Snowflake, is null for any other adapter).
description: Query ID in the data warehouse, if returned by the adapter (currently only supported in Snowflake and ClickHouse, is null for any other adapter).
Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 7, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor | ⚡ Quick win

🧩 Analysis chain

🌐 Web query:

What is the first released dbt-clickhouse version that includes AdapterResponse.query_id support from PR https://github.com/ClickHouse/dbt-clickhouse/pull/634?

💡 Result:

No released version of dbt-clickhouse includes AdapterResponse.query_id support from PR #634. The feature request to populate ClickHouse query_id in AdapterResponse was opened on 2026-02-25 [1], and the current main branch code in connections.py still returns AdapterResponse(_message=status) without setting query_id [2]. No changelog or release notes mention this feature [3][4][5][6], and PR #634 does not appear in search results or open pull requests [7]. Latest release is v1.10.0 from 2026-02-16 [8][4], predating the issue. The PR likely does not exist or has not been merged/released as of 2026-05-07.

Citations:

Remove or qualify ClickHouse from current support list

Line 217 claims ClickHouse is currently supported for query_id, but this feature has not been released in any dbt-clickhouse version and does not appear to be implemented in the main branch. Remove ClickHouse from the description or explicitly mark it as "planned/unreleased" to prevent misleading users.

🤖 Prompt for AI Agents 
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@models/run_results.yml` at line 217, The description for the "query_id" field
in models/run_results.yml incorrectly states ClickHouse is currently supported;
update the description string for the query_id field to either remove ClickHouse
from the supported adapters list or explicitly mark ClickHouse as
"planned/unreleased" (e.g., "supported in Snowflake; ClickHouse support
planned/unreleased") so users aren't misled—modify the description value
referenced as the description for query_id in run_results.yml accordingly.

Copy link
Copy Markdown
Author

@29antonioac 29antonioac May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is merged to main, just not tagged & released, so this PR should wait until that point 😄

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@29antonioac, thanks for the clarification! That makes sense — since the feature is merged to main in dbt-clickhouse but not yet tagged/released, the current description could mislead users on published versions.

A few suggestions to make it easier to track and land this PR at the right time:

  1. Convert to a draft PR until the dbt-clickhouse release is published, so it's clear it's pending a dependency.
  2. Add a PR description note linking to the specific dbt-clickhouse release once it's tagged (e.g., Requires dbt-clickhouse >= vX.Y.Z), so reviewers and mergers know exactly when it's safe to land.
  3. Optionally, you could update the description in this PR to include the minimum version requirement once known, e.g.: 
    description: Query ID in the data warehouse, if returned by the adapter (currently only supported in Snowflake and ClickHouse >= vX.Y.Z, is null for any other adapter).

Once the dbt-clickhouse release is out, this PR should be straightforward to merge! 🎉


- name: thread_id
data_type: string
Expand Down
Loading