Skip to content

Add "Allow screenshots" option to the Screen lock#6914

Draft
bxdxnn wants to merge 1 commit into
element-hq:developfrom
bxdxnn:feat/no-flag-secure
Draft

Add "Allow screenshots" option to the Screen lock#6914
bxdxnn wants to merge 1 commit into
element-hq:developfrom
bxdxnn:feat/no-flag-secure

Conversation

@bxdxnn
Copy link
Copy Markdown
Contributor

@bxdxnn bxdxnn commented May 29, 2026

Content

Add an "Allow screenshots" option (disabled by default) in the "Screen lock" to disable FLAG_SECURE

Motivation and context

Fixes #6912

Screenshots / GIFs

Tests

  • Enable the option and take a screnshot

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • I am aware of the etiquette.
  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bxdxnn bxdxnn requested a review from a team as a code owner May 29, 2026 20:45
@bxdxnn bxdxnn requested review from ganfra and removed request for a team May 29, 2026 20:45
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • If your pull request adds a feature or modifies the UI, this should have an equivalent pull request in the Element X iOS repo unless it only affects an Android-only behaviour or is behind a disabled feature flag, since we need parity in both clients to consider a feature done. It will also need to be approved by our product and design teams before being merged, so it's usually a good idea to discuss the changes in a Github issue first and then start working on them once the approach has been validated.
  • Your branch should be based on origin/develop, at least when it was created.
  • The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

@github-actions github-actions Bot added the Z-Community-PR Issue is solved by a community member's PR label May 29, 2026
@bmarty
Copy link
Copy Markdown
Member

bmarty commented Jun 1, 2026

In #6912, the author mentioned being able to block screenshot without configuring a PIN code. This is not covered by the PR, but it would require more changes because the "Screen lock" screen is only accessible once a PIN code has been configured. We would need some product thinking about it first.

* Check if screenshots are allowed when the lock screen is enabled.
* @return true if screenshots are allowed, false otherwise.
*/
fun isAllowScreenshotsAllowed(): Flow<Boolean>
Copy link
Copy Markdown
Member

@bmarty bmarty Jun 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isScreenshotAllowed?

@bxdxnn bxdxnn marked this pull request as draft June 1, 2026 09:39
@bxdxnn
Copy link
Copy Markdown
Contributor Author

bxdxnn commented Jun 1, 2026

OK, I agree, probably was too rushed... will wait for the product decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Feature request] Add toggle to enable/disable screenshots

2 participants