Add /myroomnick slash command to change your display name in the current room#6865
Add /myroomnick slash command to change your display name in the current room#6865bxdxnn wants to merge 5 commits into
/myroomnick slash command to change your display name in the current room#6865Conversation
|
Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #6865 +/- ##
===========================================
- Coverage 81.26% 81.25% -0.01%
===========================================
Files 2652 2652
Lines 74404 74410 +6
Branches 9650 9650
===========================================
- Hits 60463 60462 -1
- Misses 10378 10388 +10
+ Partials 3563 3560 -3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Thinking about it only now, sorry. Maybe the application should prevent the user from updating their display name in a room when Not sure, pinging @mxandreas |
That depends on element-hq/synapse#17048, we shouldn't just do client-side checks but also make Synapse to block it. If that's required for this feature, I can try to fix it in Synapse too. |
|
Synapse fix is at element-hq/synapse#19811, but it's not blocking to merge it in the app meanwhile. |
bmarty
left a comment
There was a problem hiding this comment.
Thanks for the update and the PR on Synapse!
Content
Motivation and context
Feature parity with Element Classic and it has been frequently requested.
Screenshots / GIFs
Tests
Tested devices
Checklist