Skip to content

Add /myroomnick slash command to change your display name in the current room#6865

Open
bxdxnn wants to merge 5 commits into
element-hq:developfrom
bxdxnn:feat/myroomnick
Open

Add /myroomnick slash command to change your display name in the current room#6865
bxdxnn wants to merge 5 commits into
element-hq:developfrom
bxdxnn:feat/myroomnick

Conversation

@bxdxnn
Copy link
Copy Markdown
Contributor

@bxdxnn bxdxnn commented May 26, 2026

Content

Motivation and context

Feature parity with Element Classic and it has been frequently requested.

Screenshots / GIFs

Tests

  • Type the command
    • Check that your display name have changed only in the current room

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

  • This PR was made with the help of AI:
    • Yes. In this case, please request a review by Copilot.
    • No.
  • Changes have been tested on an Android device or Android emulator with API 24
  • UI change has been tested on both light and dark themes
  • Accessibility has been taken into account. See https://github.com/element-hq/element-x-android/blob/develop/CONTRIBUTING.md#accessibility
  • Pull request is based on the develop branch
  • Pull request title will be used in the release note, it clearly defines what will change for the user
  • Pull request includes screenshots or videos if containing UI changes
  • You've made a self review of your PR

@bxdxnn bxdxnn requested a review from a team as a code owner May 26, 2026 07:41
@bxdxnn bxdxnn requested review from bmarty and removed request for a team May 26, 2026 07:41
@github-actions
Copy link
Copy Markdown
Contributor

Thank you for your contribution! Here are a few things to check in the PR to ensure it's reviewed as quickly as possible:

  • If your pull request adds a feature or modifies the UI, this should have an equivalent pull request in the Element X iOS repo unless it only affects an Android-only behaviour or is behind a disabled feature flag, since we need parity in both clients to consider a feature done. It will also need to be approved by our product and design teams before being merged, so it's usually a good idea to discuss the changes in a Github issue first and then start working on them once the approach has been validated.
  • Your branch should be based on origin/develop, at least when it was created.
  • The title of the PR will be used for release notes, so it needs to describe the change visible to the user.
  • The test pass locally running ./gradlew test.
  • The code quality check suite pass locally running ./gradlew runQualityChecks.
  • If you modified anything related to the UI, including previews, you'll have to run the Record screenshots GH action in your forked repo: that will generate compatible new screenshots. However, given Github Actions limitations, it will prevent the CI from running temporarily, until you upload a new commit after that one. To do so, just pull the latest changes and push an empty commit.

@github-actions github-actions Bot added the Z-Community-PR Issue is solved by a community member's PR label May 26, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented May 26, 2026

Codecov Report

❌ Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.25%. Comparing base (f447560) to head (4b99e59).
⚠️ Report is 69 commits behind head on develop.

Files with missing lines Patch % Lines
...droid/libraries/matrix/impl/room/JoinedRustRoom.kt 0.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #6865      +/-   ##
===========================================
- Coverage    81.26%   81.25%   -0.01%     
===========================================
  Files         2652     2652              
  Lines        74404    74410       +6     
  Branches      9650     9650              
===========================================
- Hits         60463    60462       -1     
- Misses       10378    10388      +10     
+ Partials      3563     3560       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmarty
Copy link
Copy Markdown
Member

bmarty commented May 29, 2026

Thinking about it only now, sorry. Maybe the application should prevent the user from updating their display name in a room when HomeserverCapabilitiesProvider.canChangeDisplayName() returns false.

Not sure, pinging @mxandreas

Copy link
Copy Markdown
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my question above

@bxdxnn
Copy link
Copy Markdown
Contributor Author

bxdxnn commented May 29, 2026

Thinking about it only now, sorry. Maybe the application should prevent the user from updating their display name in a room when HomeserverCapabilitiesProvider.canChangeDisplayName() returns false.

Not sure, pinging @mxandreas

That depends on element-hq/synapse#17048, we shouldn't just do client-side checks but also make Synapse to block it.

If that's required for this feature, I can try to fix it in Synapse too.

@bxdxnn
Copy link
Copy Markdown
Contributor Author

bxdxnn commented May 29, 2026

Synapse fix is at element-hq/synapse#19811, but it's not blocking to merge it in the app meanwhile.

Copy link
Copy Markdown
Member

@bmarty bmarty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update and the PR on Synapse!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Z-Community-PR Issue is solved by a community member's PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants