Skip to content

Conversation

@eleith
Copy link
Owner

@eleith eleith commented Dec 13, 2025

modernize codebase with latest best practices and tooling

  1. adopted vitest and increase test coverage
  2. only support node 20, 22, 24 (older versions of emailjs are required if you want node 18 support)
  3. remove docjs in favor of direct typing throughout
  4. add scripts for testing against a local smtp server

@eleith eleith force-pushed the modernize-codebase branch from 5282dc9 to f0938b3 Compare December 13, 2025 13:15
@eleith eleith force-pushed the modernize-codebase branch 3 times, most recently from 762dac9 to 8a242ff Compare December 13, 2025 15:13
@eleith eleith force-pushed the modernize-codebase branch from 8a242ff to 28009bf Compare December 13, 2025 15:14
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR modernizes the emailjs codebase by adopting Vitest for testing, restructuring code into a src/ directory with proper ES modules, and dropping support for Node.js versions older than 20. The migration removes docjs annotations in favor of direct TypeScript typing and includes comprehensive test coverage using both unit and integration tests.

Key Changes:

  • Migrated from Ava to Vitest testing framework with increased test coverage
  • Restructured codebase into src/ directory with modular organization
  • Updated TypeScript configuration for ES2022 and NodeNext module resolution

Reviewed changes

Copilot reviewed 58 out of 63 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
vitest.config.ts New Vitest configuration with v8 coverage provider and 80% thresholds
tsconfig.json Updated for ES2022 target, NodeNext modules, and Vitest globals
yarn.lock Completely removed (likely switching to package.json only)
rollup.config.ts Removed (build process changed)
src/*.ts New modular source structure with index, error, connection, message, etc.
src/*.test.ts New unit and integration tests using Vitest
test/*.ts Old Ava tests removed

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 58 out of 63 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@eleith eleith merged commit 911ff7a into main Dec 15, 2025
15 checks passed
@eleith eleith deleted the modernize-codebase branch December 15, 2025 20:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants