-
Notifications
You must be signed in to change notification settings - Fork 235
initial modernization migration #348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
5282dc9 to
f0938b3
Compare
762dac9 to
8a242ff
Compare
8a242ff to
28009bf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR modernizes the emailjs codebase by adopting Vitest for testing, restructuring code into a src/ directory with proper ES modules, and dropping support for Node.js versions older than 20. The migration removes docjs annotations in favor of direct TypeScript typing and includes comprehensive test coverage using both unit and integration tests.
Key Changes:
- Migrated from Ava to Vitest testing framework with increased test coverage
- Restructured codebase into
src/directory with modular organization - Updated TypeScript configuration for ES2022 and NodeNext module resolution
Reviewed changes
Copilot reviewed 58 out of 63 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
vitest.config.ts |
New Vitest configuration with v8 coverage provider and 80% thresholds |
tsconfig.json |
Updated for ES2022 target, NodeNext modules, and Vitest globals |
yarn.lock |
Completely removed (likely switching to package.json only) |
rollup.config.ts |
Removed (build process changed) |
src/*.ts |
New modular source structure with index, error, connection, message, etc. |
src/*.test.ts |
New unit and integration tests using Vitest |
test/*.ts |
Old Ava tests removed |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
Copilot reviewed 58 out of 63 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
modernize codebase with latest best practices and tooling