fix: don't cache empty releases on server error#256
Open
dsanders11 wants to merge 1 commit into
Open
Conversation
dsanders11
force-pushed
the
fix/no-cache-errors
branch
2 times, most recently
from
310d61d to
a1c8c67
Compare
dsanders11
force-pushed
the
fix/no-cache-errors
branch
from
a1c8c67 to
81a6151
Compare
dsanders11
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
We don't want to cache an empty placeholder value here, we want to throw an error, otherwise downstream users of
/releases.jsonwill incorrectly get an empty list of releases.Checklist