Skip to content

test: fix race in FetchDownloader write-stream failure test #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarshallOfSound merged 1 commit into from
Apr 22, 2026
+5 −2
Merged

test: fix race in FetchDownloader write-stream failure test #389

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions test/FetchDownloader.network.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,10 +50,12 @@ describe('FetchDownloader', () => {
it('should throw an error if the file write stream fails', async () => {
const downloader = new FetchDownloader();
const createWriteStream = fs.createWriteStream;
const writeError = new Error('ENOSPC: no space left on device, write');
const spy = vi.spyOn(fs, 'createWriteStream');
spy.mockImplementationOnce((path: PathLike) => {
const stream = createWriteStream(path);
setTimeout(() => stream.emit('error', 'bad write error thing'), 0);
stream._write = (_chunk, _encoding, callback): void => callback(writeError);
stream._writev = (_chunks, callback): void => callback(writeError);
return stream;
});
await withTempDirectory(async (dir) => {
Expand All @@ -63,8 +65,9 @@ describe('FetchDownloader', () => {
'https://github.com/electron/electron/releases/download/v2.0.18/SHASUMS256.txt',
testFile,
),
).rejects.toMatchInlineSnapshot(`"bad write error thing"`);
).rejects.toThrowError(writeError);
}, TempDirCleanUpMode.CLEAN);
spy.mockRestore();
});

it('should download to a deep uncreated path', async () => {
Expand Down