Skip to content

refactor: move more of start fiddle flow to main process#1935

Draft
dsanders11 wants to merge 8 commits intomainfrom
build/refactor-start-fiddle-ipc
Draft

refactor: move more of start fiddle flow to main process#1935
dsanders11 wants to merge 8 commits intomainfrom
build/refactor-start-fiddle-ipc

Conversation

@dsanders11
Copy link
Copy Markdown
Member

Currently when a fiddle is started, the START_FIDDLE IPC event is sent from the renderer to the main process, with all the parameters needed to start the fiddle. This PR changes the flow to drop the parameters on START_FIDDLE and instead add a new GET_START_FIDDLE_OPTIONS IPC request from main -> renderer to get those parameters. This lets us decouple the starting of a fiddle and will let us isolate the run button.

This also lets us consolidate more of the run fiddle logic into the main process and simplifies the flow instead of having a split brain where the renderer was driving some of the process. As a result we can drop the CLEANUP_DIRECTORY and DELETE_USER_DATA IPC events.

@coveralls
Copy link
Copy Markdown

coveralls commented May 7, 2026

Coverage Status

coverage: 88.64% (-0.02%) from 88.661% — build/refactor-start-fiddle-ipc into main

@dsanders11 dsanders11 marked this pull request as ready for review May 7, 2026 18:58
@dsanders11 dsanders11 requested review from a team and codebytere as code owners May 7, 2026 18:58
@dsanders11 dsanders11 marked this pull request as draft May 8, 2026 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants