Skip to content

test: add interactive macOS dialog tests#50363

Merged
jkleinsc merged 1 commit intomainfrom
macos-dialog-tests
Mar 26, 2026
Merged

test: add interactive macOS dialog tests#50363
jkleinsc merged 1 commit intomainfrom
macos-dialog-tests

Conversation

@codebytere
Copy link
Copy Markdown
Member

@codebytere codebytere commented Mar 19, 2026

Description of Change

Introduces a new @electron-ci/dialog-helper native Node.js addon that can inspect and control live macOS dialog sheets through their native window handles. The addon reads dialog metadata such as type, message, detail text, button labels, and checkbox state from attached NSAlert, NSOpenPanel, and NSSavePanel sheets, and can programmatically click buttons, toggle the suppression checkbox, or dismiss file dialogs.

Checklist

Release Notes

Notes: none

@codebytere codebytere added target/41-x-y PR should also be added to the "41-x-y" branch. target/42-x-y PR should also be added to the "42-x-y" branch. labels Mar 19, 2026
@codebytere codebytere force-pushed the macos-dialog-tests branch 2 times, most recently from a70a8cc to 2b50036 Compare March 20, 2026 15:29
@codebytere codebytere marked this pull request as ready for review March 23, 2026 09:24
Copy link
Copy Markdown
Member

@VerteDinde VerteDinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's goooooooooo

@jkleinsc jkleinsc merged commit 8cb61e8 into main Mar 26, 2026
66 checks passed
@jkleinsc jkleinsc deleted the macos-dialog-tests branch March 26, 2026 21:06
@release-clerk
Copy link
Copy Markdown

release-clerk Bot commented Mar 26, 2026

No Release Notes

@trop
Copy link
Copy Markdown
Contributor

trop Bot commented Mar 26, 2026

I have automatically backported this PR to "42-x-y", please check out #50527

@trop trop Bot added in-flight/42-x-y and removed target/42-x-y PR should also be added to the "42-x-y" branch. labels Mar 26, 2026
@trop
Copy link
Copy Markdown
Contributor

trop Bot commented Mar 26, 2026

I have automatically backported this PR to "41-x-y", please check out #50528

@trop trop Bot added in-flight/41-x-y merged/41-x-y PR was merged to the "41-x-y" branch. merged/42-x-y PR was merged to the "42-x-y" branch. and removed target/41-x-y PR should also be added to the "41-x-y" branch. in-flight/41-x-y in-flight/42-x-y labels Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merged/41-x-y PR was merged to the "41-x-y" branch. merged/42-x-y PR was merged to the "42-x-y" branch. semver/none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants