feat: add id, groupId, and groupTitle support for Windows notifications#50328
Open
bitdisaster wants to merge 6 commits intoelectron:mainfrom
Open
feat: add id, groupId, and groupTitle support for Windows notifications#50328bitdisaster wants to merge 6 commits intoelectron:mainfrom
bitdisaster wants to merge 6 commits intoelectron:mainfrom
Conversation
fa28467 to
6644704
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR extends the Windows notification implementation to support the
id,groupId, andgroupTitleproperties, bringing feature parity with macOS and adding Windows-specific header grouping support.Changes
New Features:
idproperty now works on Windows — maps directly to the toast notification’sTagproperty for deduplication and removal.groupIdproperty now works on Windows — it serves two purposes:idit uniquely identifies a notification in memoryidproperty for grouping in Action CentergroupTitleproperty (Windows only) — when bothgroupIdandgroupTitleare specified, a<header>element is generated in the toast XML to display a visual group header.Validation:
idandgroupIdon Windows (max 64 UTF-16 characters) with descriptive error messages.Internal Changes:
idis now used directly as the Windows toastTag.groupandtagvalues whenELECTRON_DEBUG_NOTIFICATIONSis set.Tests:
id,groupIdproperties).groupTitle.Example Usage
Checklist
npm testpassesRelease Notes
Notes: